Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

qwed_tax/guards/tds_guard.py (1)

85-124: 🧹 Nitpick | 🔵 Trivial | ⚡ Quick win

Consider extracting the common to_diagnostic() logic into a shared helper.

The to_diagnostic() implementation is identical across all three guards migrated in this PR (TDSGuard, InputCreditGuard, GSTGuard). Since these guards are being added together, consolidating the conversion logic now would prevent future divergence and reduce maintenance burden.

♻️ Suggested consolidation approach

Create a shared helper in qwed_tax/diagnostics.py:

def legacy_result_to_diagnostic(
    result: Dict[str, Any],
    unknown_constraint_id: str = "UNKNOWN",
) -> TaxDiagnosticResult:
    """Convert a legacy guard result dict to TaxDiagnosticResult.
    
    Backward-compatible migration helper for guards that produce audit_trace.
    """
    verified = result.get("verified", False)
    audit_trace = result.get("audit_trace")

    if not verified:
        return TaxDiagnosticResult.blocked(
            agent_message="Tax verification could not be completed.",
            developer_fields={
                "constraint_id": audit_trace["rule_id"] if audit_trace else unknown_constraint_id,
                "audit_trace": audit_trace,
                "error": result.get("error"),
                "deduction": result.get("deduction"),
                "net_payable": result.get("net_payable"),
            },
        )

    if audit_trace is None:
        raise ValueError(
            "VERIFIED result requires audit_trace — "
            "use UNVERIFIABLE if no evidence was established."
        )

    return TaxDiagnosticResult.verified(
        agent_message="Tax verification completed.",
        developer_fields={
            "constraint_id": audit_trace["rule_id"],
            "statute": audit_trace.get("statute"),
            "jurisdiction": audit_trace.get("jurisdiction"),
            "audit_trace": audit_trace,
            "deduction": result.get("deduction"),
            "net_payable": result.get("net_payable"),
        },
        evidence=audit_trace,
    )

Then replace each guard's to_diagnostic() with:

`@staticmethod`
def to_diagnostic(result: Dict[str, Any]) -> TaxDiagnosticResult:
    """Convert legacy result to TaxDiagnosticResult."""
    return legacy_result_to_diagnostic(result, unknown_constraint_id="TDS_UNKNOWN")

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@qwed_tax/guards/tds_guard.py` around lines 85 - 124, The to_diagnostic()
static method in TDSGuard contains identical logic that is duplicated across
InputCreditGuard and GSTGuard. Extract this common conversion logic into a
shared helper function called legacy_result_to_diagnostic() in
qwed_tax/diagnostics.py, parameterizing the unknown_constraint_id so each guard
can pass its own identifier (e.g., "TDS_UNKNOWN" for TDSGuard). Then replace the
entire to_diagnostic() method body in TDSGuard with a single call to this shared
helper, passing "TDS_UNKNOWN" as the constraint identifier argument.